search

nikoschalikias / eggbotcode

Automatically exported from code.google.com/p/eggbotcode
0 stars 1 forks source link

Ignore unsupported SVG elements unrelated to rendering; provide more informative warnings for other unsupported elements #42

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
The Eggbot Control extension silently ignores some unsupported SVG elements 
while providing warnings about other unsupported elements.

To the list of silently ignored elements a few additional elements should be 
added.  At the same time, a more helpful warning about embedded bitmaps might 
be provided.  Finally, the generic warning about unsupported elements 
encountered might include the element's tag name so as to aid in any diagnosis.

Original issue reported on code.google.com by newman.d...@gmail.com on 3 May 2011 at 10:29

GoogleCodeExporter commented 8 years ago 
Changes checked in as a revision 213.  My testing went fine.  However, a check 
by other eyes would be a Good Thing.

To the list of silently ignored SVG elements, I have added

cursor
  Not relevant to rendering

radialGradient, linearGradient
  Since pattern is silently ignored, I figured these should be also.  They deal with fills of objects and as the Eggbot only  itself with object outlines, these all seem safe to silently ignore

style
  This element is actually a reference to an external style sheet.  As the Eggbot presently ignores style directives when rendering, this seems safe to ignore -- it has no additional impact on rendering than does ignoring a style attribute.

color-profile
  Gamma curves, color temperature, etc. is hardly relevant to Eggbot rendering.

title
  Used for metadata about the design (e.g., copyright, authorship).  All data which is not rendered.

I've made it such that for <image> elements, the warning mentions using the 
Trace Bitmap tool.  It also mentions the known issue on OS X whereby 
cut-n-paste can result in pasting in bitmap images.

Warnings for generic unsupported SVG elements include the tag's name.

Also, only one warning is now issued for each unsupported SVG element-type.  
So, if there are three text objects, the text warning is only generated once.  
This may alleviate some of the objections which experienced users have to the 
warning noise.

Original comment by newman.d...@gmail.com on 3 May 2011 at 10:42

GoogleCodeExporter commented 8 years ago 
Dan,
Thank you for doing this -- it will be a big help.

>a check by other eyes would be a Good Thing

I will test this, and we may want to recruit one or two additional beta testers 
before the next release-- there have been a lot of little changes, now.

Original comment by windell@oskay.net on 3 May 2011 at 10:53