search

nikosdion / joomla_extensions_development

Joomla Extensions Development: a reference book
GNU Free Documentation License v1.3
10 stars 1 forks source link

Model naming consistency. #10

Closed pjdevries closed 1 year ago

pjdevries commented 1 year ago

Pull Request for Issue #7.

Summary of Changes

Renames DatabaseModel to BaseDatabaseModel.

Reasoning

In the ItemModel and ListModel descriptions of Chapter 2: Components - Models, you refer to "DatabaseModel". For consistency with the preceding sections on that page, I think it makes sense to rename those to BaseDatabasModel.

@nikosdion You closed the issue, either because you did not agree with my suggestion or because you assumed it was part of another PR, which it wasn't (my fault). I guess the latter, so I created this PR. If it turns out to be the former, ignore the PR and accept my apologies for misunderstanding.

nikosdion commented 1 year ago

Yes, I thought your previous PR fixed that.