nikosdion / joomla_extensions_development

Joomla Extensions Development: a reference book
GNU Free Documentation License v1.3
10 stars 1 forks source link

Possible mistake on page "Pushing dependencies to the Router" #28

Closed pjdevries closed 1 year ago

pjdevries commented 1 year ago

The bottom of page Pushing dependencies to the Router shows the following code:

$container->registerServiceProvider(
  new \Acme\Component\Example\Administrator\Service\Provider\RouterFactoryProvider(
    '\\Acme\\Example'
  )
);

It appears to me that the \\Component segment is missing from the RouterFactoryProvider::constuct() namespace parameter. Shouldn't it be:


$container->registerServiceProvider(
  new \Acme\Component\Example\Administrator\Service\Provider\RouterFactoryProvider(
    '\\Acme\\Component\\Example'
  )
);
```?
nikosdion commented 1 year ago

Yes, that's missing. Can you please do a PR?