search

nikosdion / joomla_extensions_development

Joomla Extensions Development: a reference book
GNU Free Documentation License v1.3
10 stars 1 forks source link

Align code with the joomal core #32

Closed sandewt closed 1 year ago

sandewt commented 1 year ago

Pull Request for Issue # .

Summary of Changes

Change:

<folder>services</folder>
<folder plugin="example">src</folder>

To:

<folder plugin="example">services</folder>
<folder>src</folder>

Reasoning

see: https://issues.joomla.org/tracker/joomla-cms/40204

nikosdion commented 1 year ago

I hope you do realise that I was the first developer to ever write any plugins whatsoever in the Joomla 4 way — BEFORE the core Joomla did that. I even contributed the first Joomla 4 native plugin to the core (WebAuthn). I was the one who introduced the idea of migrating core plugins to the native Joomla 4 format, starting with the System - Page Cache plugin. So, yeah, I think I know a thing or two about Joomla! plugins, thank you very much 😉

The installer simply looks for the plugin attribute in any folder or file element to determine the plugin name (which is stupid if you ask me; this should be an attribute of the root extension element). It does not matter which element you put it on.

I chose to use the src folder because it makes it far more clear to less experienced developers that the plugin's PHP code is in the src folder. If someone looks at a plugin and starts reading the services/provider.php file we've lost them for good.

Making the code easy for new developers to follow is INFINITELY more important than the bullshit reasoning of alpha sorting. We write code for humans, not machines. If you want to write code for machines that humans can't read there's an entire programming language for it, called Perl.

I'll stick with my convention.

sandewt commented 1 year ago

Thank you for your feedback. I'm trying to understand Joomla better and make a meaningful contribution. And hope for the best. No more. 😄