search

nikosgram / gringotts

Gringotts is an item-based economy plugin for the Bukkit Minecraft server platform. Unlike earlier economy plugins, all currency value and money transactions are based on actual items in Minecraft, per default emeralds.
https://www.spigotmc.org/resources/gringotts.42071/
BSD 2-Clause "Simplified" License
42 stars 35 forks source link

Gringotts Breaking Compatibility with Other Plugins on 2.12.5 #154

Closed Relaxing9 closed 1 year ago

Relaxing9 commented 1 year ago

Describe the bug Gringotts is creating an NPE

To Reproduce Steps to reproduce the behavior:

  1. Download Autorank & Gringotts (also have a Permissions Provider)
  2. See example configuration below (additional context) for further information on how configured
  3. Try to check if you completed an Autorank path and if Gringotts money reward is in the middle of the reward list it breaks the rest of the reward types.

Expected behavior No errors to occur & you are able to receive all items without hassle. Due to this error I had to edit my Autorank configuration file to list Gringotts rewards as the last item on the list or else it breaks Autorank in handing out other rewards. I am guessing it has something to do with the new Shulker Box features.

Issue is not present in 2.12.4-SNAPSHOT

Desktop (please complete the following information):

Additional context Example Autorank Configuration Error Generated for Gringotts when Integrated with Autorank

Also breaks UltimateRewards when setting money as a reward, only downgrading to 2.12.4-SNAPSHOT resolves it.

nikosgram commented 1 year ago

Is it possible to share the Gringotts config? There is a possibility that the denomination type is empty or incorrect.

nikosgram commented 1 year ago

I made a few changes regards this issue. Can the problem be reproduced with Gringotts version 2.12.6-SNAPSHOT and send the log in this thread?

You can find the Gringotts snapshot on the link below:

https://github.com/nikosgram/gringotts/releases/download/2.12.6-SNAPSHOT/gringotts-2.12.6-SNAPSHOT.jar

Relaxing9 commented 1 year ago

Is it possible to share the Gringotts config? There is a possibility that the denomination type is empty or incorrect.

Here is the config: Link Will need to test your Snapshot that you provided though.

Relaxing9 commented 1 year ago

It not longer errors with UltimateRewards as for Autorank will need to manually configure that, but if it is already not showing it on UltimateRewards, it shouldn't be able to reproduce it on Autorank either.

Will attempt to set that up though to verify.

Relaxing9 commented 1 year ago

No longer able to replicate this error on Autorank either no logs generated. Thanks for solving the issue.

I'll leave it for you to lock.