search

nikp123 / scrcpy-desktop

Run an Android desktop environment off of a device using ONLY scrcpy
GNU General Public License v2.0
214 stars 15 forks source link

Fix obtaining display ID up untill android 12L at least - fix #1 #13

Closed Pawloland closed 1 year ago

Pawloland commented 1 year ago

Hi again. I tested it with Android Studio EE Desktop image emulator (12L) on windows 10. Please make sure it works for you and check if I didn't update the linux script the wrong way.

nikp123 commented 1 year ago

Thanks for contributing, however I wont be having the capacity to test this for a while. Sorry for the inconvenience

nikp123 commented 1 year ago

Hopefully you dont mind the wait

Pawloland commented 1 year ago

Don't worry, I just made a PR to make other people have a fix. Don't merge yet because I found a bug with a grep for obtaining display ID. Any ID containing 0 is omitted, so 0 but also 10, 101 etc. so the script crashes with those.

Pawloland commented 1 year ago

Should be good now

nikp123 commented 1 year ago

Sorry for the wait, I don't have much capacity for testing (as my phone is quite outdated) so merging this on the basis that the code LGTM.