[Feature Request] Pull colors from pywal

[make-42]

This works...

[make-42]

Closes #59

[make-42]

I'll do my best!

[nikp123]

I'll do my best!

Good luck and have fun

[make-42]

I made all the changes you asked for except for the dynamic color reload part because I have no idea how to change the colors without triggering a whole reload.

[nikp123]

I made all the changes you asked for except for the dynamic color reload part because I have no idea how to change the colors without triggering a whole reload.

Yeah because it isn't really obvious, I'd never thought of having code that redraws colors outside of the main loop, hence why a bit of architectural elbow grease is required unfortunately.

[make-42]

something like this? it crashes here though (null pointer dereference) src/xava.c

58    output->func.clear(xava);

[nikp123]

Funnily enough it doesn't for me, can you clear the compile cache, maybe somethings up.

[make-42]

I'm on X11, that might be the issue. the clear function might be erroring out on x11.

[nikp123]

There seems to be an bug with IONotify since it keeps calling non-stop.

[make-42]

Maybe yes

[nikp123]

Ok I found out whats the bug. Firstly you should actually check for an event instead of blindly reloading. Secondly the clear call seg faults on some systems because its supposed to be called from within the main thread (OpenGL moment).

We need an way to signal to the thread that we are redrawing. Exposing redrawWindow might be the solution here.

[make-42]

What do you mean by checking for an event instead of blindly reloading?

[make-42]

oh

[make-42]

i get it

[nikp123]

Anyway I fixed it, sending the patch soon enough

[make-42]

Okay

[nikp123]

fixes.patch.zip

[nikp123]

Apply that patch, push here and I'll rebase

Additionally test out how it works for you.

[nikp123]

Remove the glDrawArrays line I added by accident, it shouldn't be there

[nikp123]

Actually don't, let me squash and merge this.

[make-42]

okay

[make-42]

It doesn't crash but doesn't update the colors either on X11 until a restart.

[nikp123]

It doesn't crash but doesn't update the colors either on X11 until a restart.

Hm weird

[nikp123]

It doesn't crash but doesn't update the colors either on X11 until a restart.

I've tested both X11 and Wayland, neither seem to have the issue on both Cairo and OpenGL

Can you send your config just in case?

[make-42]

config

[nikp123]

config

works even with that config :thinking:

[make-42]

I'll do some investigation

[make-42]

Okay. I fixed it. Line 18 of pywal.c it's ".cache" and not ".config" that should be used.

[make-42]

It didn't register the file properly and probably read from xrdb on startup instead.

[make-42]

fix.zip

[nikp123]

@make-42 oh whoops, my bad

sent the patch to master

[make-42]

Haha! Thank you!