nikshinde1996 / xkcd-cli

Python based cli-tool to explore xkcd web-comic content from your terminal :computer:
MIT License
4 stars 0 forks source link

Timeout increase #1

Open brunolnetto opened 2 years ago

brunolnetto commented 2 years ago

Hi, would you mind to increase the timeout for the requests? They are too fast to read the comics

nikshinde1996 commented 2 years ago

Nice catch @brunolnetto, I'd love to accept your contribution, feel free to raise the PR if possible.

brunolnetto commented 2 years ago

This one specifically I do not know how to do. I have the following features in mind:

brunolnetto commented 2 years ago

Nevermind, they are on log-info tag

nikshinde1996 commented 2 years ago

This one specifically I do not know how to do. I have the following features in mind:

  • Fetch comic by date
  • Print "alt" and title from comic

@brunolnetto sounds great... looking forward to see PRs

brunolnetto commented 2 years ago

I created the following python notebook. May you evaluate it? https://github.com/brunolnetto/grad_essays/tree/main/xkcd-cli_contribution

nikshinde1996 commented 2 years ago

I created the following python notebook. May you evaluate it? https://github.com/brunolnetto/grad_essays/tree/main/xkcd-cli_contribution

Looks good to me @brunolnetto

brunolnetto commented 2 years ago

It is a little bit slow. Could you send an e-mail to Randall for him to provide an endpoint route "/from/:from_index/to/:to_index" and "/from/:from_date/to/:to_date"?