Laravel Linter - Githubissues

nikspyratos / toybox

Opinionated TALL stack starter kit for Laravel solopreneurs

MIT License

117 stars 6 forks source link

Laravel Linter #7

Closed nikspyratos closed 4 months ago

nikspyratos commented 4 months ago

This pull request includes changes and recommendations for crafting your application "The Laravel Way". Feel free to commit any additional changes to the shift-113554 branch.

Before merging, you need to:

Checkout the shift-113554 branch
Review all pull request comments for additional changes
Thoroughly test your application (no tests?, no CI?)

Much of the lint detected may be automatically fixed by running the Laravel Fixer or tasks within the Shift Workbench.

nikspyratos commented 4 months ago

:x: The following configuration files differ from the Laravel defaults. If you are modifying configuration values directly, consider using an environment variable instead to keep these files maintainable. You should compare your configuration files against the latest version and merge any updates.

[ ] config/app.php
[ ] config/auth.php
[ ] config/broadcasting.php
[ ] config/cache.php
[ ] config/database.php
[ ] config/filesystems.php
[ ] config/hashing.php
[ ] config/logging.php
[ ] config/mail.php
[ ] config/queue.php
[ ] config/services.php
[ ] config/session.php
[ ] config/view.php

nikspyratos commented 4 months ago

:warning: The following classes do not extend the standard Laravel Model and Controller class. This may add complexity which makes your application harder to upgrade. Often a trait may be used instead of inheritance. You should review the following classes:

[ ] app/Models/Activity.php

nikspyratos commented 4 months ago

:x: Laravel 9.0 moved the resources/lang folder to a top-level lang folder. While Laravel allows the old folder, future versions may not. You should migrate this folder and add any new files.

nikspyratos commented 4 months ago

:information_source: As noted, much of the lint detected above can be automatically fixed using the Laravel Fixer. Save yourself time and clean up your codebase quickly with this new Shift.

nikspyratos commented 4 months ago

Wanted to try the linter out to see what it would do. Mostly looking at things like moving to using PHP attributes for e.g. Observers instead of the old method with declaring it in a provider.