search

nikushi / minipack

Minipack, a gem for minimalists, which can integrates Rails with webpack. It is an alternative to Webpacker.
MIT License
115 stars 22 forks source link

Fix duplicated shared chunks issue #38

Closed 0xradical closed 4 years ago

0xradical commented 4 years ago

Since every Entry object has a different object_id, a simple uniq won’t be enough. Instead, we should apply uniqueness based on the path attribute, otherwise shared chunks will be duplicated.

nikushi commented 4 years ago

Good catch! Thank you for your contribution.

nikushi commented 4 years ago

bumped as v0.3.6