nikushi / minipack

Minipack, a gem for minimalists, which can integrates Rails with webpack. It is an alternative to Webpacker.
MIT License
115 stars 22 forks source link

Add support for new webpack asset manifest format #42

Open aeaston opened 3 years ago

aeaston commented 3 years ago

Fixes https://github.com/nikushi/minipack/issues/39

webpack-asset-manifest introduced a new format in v4. In order to support prefetch and preload, assets are now nested under an assets key in the entrypoints object. This commit updates the manifest parsing logic to support this new version in addition to the previous.

More info on the manifest changes can be found here

NOTE: after making these changes, I noticed Szeliga has a PR that also solves this problem. I think the approach here is a lot simpler than adding a configuration option, although I suppose that might be more extensible in the future. I don't expect manifest formats to change often though, so I still prefer this solution personally. But merging either would solve my problem and make me happy =)