search

nilclass / slint-mode

Emacs major-mode for the Slint UI language
GNU General Public License v3.0
4 stars 1 forks source link

eglot support #1

Closed appetrosyan closed 1 week ago

appetrosyan commented 3 months ago

This is probably outside the scope, but eglot is built-in, lsp-mode is not.

So would it be reasonable to convert lsp-mode into a soft dependency and offer eglot support instead.

nilclass commented 3 months ago

That does sound reasonable to me. I'm not very familiar with eglot, but this might just be the time to change that. I'll look into it and see what I find.

nilclass commented 3 months ago

@appetrosyan I pushed some changes to the eglot-support branch, care to give it a try?

appetrosyan commented 3 months ago

Certainly! I was half expecting this to be a long term issue

erickgnavar commented 1 week ago

I tested the branch and it works well, this will be merged into main anytime soon?

nilclass commented 1 week ago

@erickgnavar it is merged now.

I was holding off until someone who uses eglot confirms that the changes work, which you just did.