search

nileane / TangerineUI-for-Mastodon

A Tangerine redesign for Mastodon's Web UI. 🍊🐘
https://nileane.fr/@TangerineUI
MIT License
405 stars 27 forks source link

Compilation failure due to deprectation warning #88

Closed cadusilva closed 8 months ago

cadusilva commented 9 months ago

Today I tried to update Mastodon to the most recent commits (as of March 1st) in the main branch, but the process was unable to complete successfully due to the following error:

Compiling...
Compilation failed:
DEPRECATION WARNING: The selector ".app-body .column-header :is(> button, .column-header__back-button)" is invalid CSS. It will be omitted from the generated CSS.
This will be an error in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/bogus-combinators

     ╷
3278 │ .app-body .column-header :is(> button, .column-header__back-button) {
     │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     ╵
    app/javascript/styles/tangerineui/tangerineui.scss 3278:1  @import
    app/javascript/styles/tangerineui.scss 2:9                 root stylesheet

DEPRECATION WARNING: The selector ".app-body .column-header :is(> button, .column-header__back-button)" is invalid CSS. It will be omitted from the generated CSS.
This will be an error in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/bogus-combinators

     ╷
3278 │ .app-body .column-header :is(> button, .column-header__back-button) {
     │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     ╵
    app/javascript/styles/tangerineui-purple/tangerineui-purple.scss 3278:1  @import
    app/javascript/styles/tangerineui-purple.scss 2:9                        root stylesheet

DEPRECATION WARNING: The selector ".app-body .column-header :is(> button, .column-header__back-button)" is invalid CSS. It will be omitted from the generated CSS.
This will be an error in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/bogus-combinators

     ╷
3278 │ .app-body .column-header :is(> button, .column-header__back-button) {
     │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     ╵
    app/javascript/styles/tangerineui-cherry/tangerineui-cherry.scss 3278:1  @import
    app/javascript/styles/tangerineui-cherry.scss 2:9                        root stylesheet

This may have changed in the last couple of days, as I was able to compile everything just fine a week ago.

nileane commented 9 months ago

Thank you for reporting. I'm not sure why these selectors would not be supported.

@vmstan Are you also seeing this error on your end? (Asking since I know you're also compiling from the latest commits)

vmstan commented 9 months ago

I did one last night and didn't have any issues, I can try one later today and see.

nileane commented 8 months ago

Are you still having this issue @cadusilva as of the latest commits?

cadusilva commented 8 months ago

Are you still having this issue @cadusilva as of the latest commits?

Yes, the issue persists. Latest result:

Compiling...
Compiled all packs in /home/mastodon/live/public/packs
DEPRECATION WARNING: The selector ".app-body .column-header :is(> button, .column-header__back-button)" is invalid CSS. It will be omitted from the generated CSS.
This will be an error in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/bogus-combinators

     ╷
3282 │ .app-body .column-header :is(> button, .column-header__back-button) {
     │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     ╵
    app/javascript/styles/tangerineui/tangerineui.scss 3282:1  @import
    app/javascript/styles/tangerineui.scss 2:9                 root stylesheet

DEPRECATION WARNING: The selector ".app-body .column-header :is(> button, .column-header__back-button)" is invalid CSS. It will be omitted from the generated CSS.
This will be an error in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/bogus-combinators

     ╷
3282 │ .app-body .column-header :is(> button, .column-header__back-button) {
     │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     ╵
    app/javascript/styles/tangerineui-purple/tangerineui-purple.scss 3282:1  @import
    app/javascript/styles/tangerineui-purple.scss 2:9                        root stylesheet

DEPRECATION WARNING: The selector ".app-body .column-header :is(> button, .column-header__back-button)" is invalid CSS. It will be omitted from the generated CSS.
This will be an error in Dart Sass 2.0.0.

More info: https://sass-lang.com/d/bogus-combinators

     ╷
3282 │ .app-body .column-header :is(> button, .column-header__back-button) {
     │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
     ╵
    app/javascript/styles/tangerineui-cherry/tangerineui-cherry.scss 3282:1  @import
    app/javascript/styles/tangerineui-cherry.scss 2:9                        root stylesheet

But when I remove the line in each variant stylesheet file, everything compiles just fine:

sed -i '/^.app-body .column-header :is(> button, .column-header__back-button) /{N;N;d}'

I tried even with a clean installation of Mastodon.

nileane commented 8 months ago

Thank you for that, I just pushed a workaround. Tell me if it's all good now :)

cadusilva commented 8 months ago

Your workaround did the trick, the compilation was successful! Thank you

Compiling...
Compiled all packs in /home/mastodon/live/public/packs