nilearn / nilearn

Machine learning for NeuroImaging in Python
http://nilearn.github.io
Other
1.17k stars 588 forks source link

change the localizer condition identifiers #2386

Open bthirion opened 5 years ago

bthirion commented 5 years ago

Current terms are in french !

kchawla-pi commented 5 years ago

@alpinho Another very simple one.

alpinho commented 5 years ago

Where are these identifiers declared?

Remi-Gau commented 1 year ago

Adding a good first issue label. This would require some pointers what part of the code base should be edited.

emdupre commented 1 year ago

I'm not sure if this is a good first issue ; it depends on the contributor's fluency in French 😉

I'm not sure where the original issue intended to point, but I do see this fetcher as affected :

data = func.fetch_localizer_button_task()
dict(zip(data['ext_vars'].dtype.names, data['ext_vars'][0]))

returns, in part:

{'participant_id': 'S02',
 'age': 20.0,
 'sex': 'M',
 'site': 'SHFJ',
 'family': 'F02',
 'language': 'French',
 'nuage2': 30.0,
 'pente_dots_lin': 0.529093,
 'couleur': nan,

These would need to be corrected on Brainomics directly, so not something a contributor could do. So, I'm not sure if this was the original intention.

I did notice, though, that the link in the dataset description should be updated as it no longer resolves.

Remi-Gau commented 1 year ago

it depends on the contributor's fluency in French

should I create a label "bonne première issue" ?