bthirion commented 4 years ago

Introduction of a cluster-level inference procedure based on the all-resolution inference procedure.

codecov[bot] commented 4 years ago

Codecov Report

Merging #402 into master will increase coverage by 0.05%. The diff coverage is 95.5%.

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
+ Coverage   92.52%   92.57%   +0.05%     
==========================================
  Files          39       39              
  Lines        4349     4433      +84     
==========================================
+ Hits         4024     4104      +80     
- Misses        325      329       +4

Impacted Files	Coverage Δ
nistats/hemodynamic_models.py	`98.07% <ø> (ø)`	:arrow_up:
nistats/tests/test_thresholding.py	`100% <100%> (ø)`	:arrow_up:
nistats/tests/test_hemodynamic_models.py	`100% <100%> (ø)`	:arrow_up:
nistats/thresholding.py	`95.87% <93.33%> (-4.13%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 32fe4d4...6f917ea. Read the comment docs.

jeromedockes commented 4 years ago

would it be possible to add a reference?

kchawla-pi commented 4 years ago

Tests and a whats_new entry.

kchawla-pi commented 4 years ago

IS this ready to merge once CI is green, or does any more work remain @bthirion ?

kchawla-pi commented 4 years ago

I accidentally overwrote the entire PR. I'm so sorry, I'll fix this.

nilearn / nistats

[WIP] All-Resolution Inference #402

Codecov Report