search

nilearn / nistats

Modeling and statistical inference on fMRI data in Python
BSD 3-Clause "New" or "Revised" License
95 stars 55 forks source link

All-resolution inference #414

Closed bthirion closed 4 years ago

bthirion commented 4 years ago

Re-created PR #402.

Introduction of a cluster-level inference procedure based on the all-resolution inference procedure.

kchawla-pi commented 4 years ago

Thanks @bthirion I will re-implement the things that I had addressed in your original PR, and no force-push this time.

kchawla-pi commented 4 years ago

Hi @bthirion We have to address the CircleCI error. Other than that this LGTM.

kchawla-pi commented 4 years ago

Once #415 has passed and merged, I'll merge this.

codecov[bot] commented 4 years ago

Codecov Report

Merging #414 into master will increase coverage by 0.05%. The diff coverage is 95.4%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #414      +/-   ##
==========================================
+ Coverage   92.52%   92.57%   +0.05%     
==========================================
  Files          39       39              
  Lines        4349     4433      +84     
==========================================
+ Hits         4024     4104      +80     
- Misses        325      329       +4
Impacted Files Coverage Δ
nistats/hemodynamic_models.py 98.07% <ø> (ø) :arrow_up:
nistats/tests/test_thresholding.py 100% <100%> (ø) :arrow_up:
nistats/thresholding.py 95.87% <93.22%> (-4.13%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d86362f...d4234c7. Read the comment docs.