search

nilearn / nistats

Modeling and statistical inference on fMRI data in Python
BSD 3-Clause "New" or "Revised" License
95 stars 55 forks source link

[WIP] Improve reporting: Correct alpha default value & enable 2 sided map_threshold #418

Closed bthirion closed 4 years ago

bthirion commented 4 years ago

Addressing #409

kchawla-pi commented 4 years ago

@bthirion I plan to implement my suggestions and merge this one soon.

codecov[bot] commented 4 years ago

Codecov Report

Merging #418 into master will increase coverage by 0.01%. The diff coverage is 94.8%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #418      +/-   ##
=========================================
+ Coverage   92.69%   92.7%   +0.01%     
=========================================
  Files          40      40              
  Lines        4533    4608      +75     
=========================================
+ Hits         4202    4272      +70     
- Misses        331     336       +5
Impacted Files Coverage Δ
nistats/reporting/glm_reporter.py 99.08% <100%> (-0.46%) :arrow_down:
nistats/regression.py 77.31% <100%> (+0.72%) :arrow_up:
nistats/tests/test_first_level_model.py 100% <100%> (ø) :arrow_up:
nistats/tests/test_regression.py 100% <100%> (ø) :arrow_up:
nistats/first_level_model.py 83.12% <85.18%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ed3e7a0...68b3b9e. Read the comment docs.

kchawla-pi commented 4 years ago

Any opinions on renaming alpha_? Also, add a whats_new entry, after pulling from master.