nilenso / honeysql-postgres

PostgreSQL extension for honeysql
http://nilenso.com
Eclipse Public License 1.0
193 stars 28 forks source link

Conflicting functions update and partition-by of clojure.core and honeysql-postgres.helpers #20

Closed codingkarthik closed 6 years ago

codingkarthik commented 6 years ago

WARNING: update already refers to: #'clojure.core/update in namespace: planista.db.utils, being replaced by: #'honeysql.helpers/update

WARNING: partition-by already refers to: #'clojure.core/partition-by in namespace: planista.db.utils, being replaced by: #'honeysql-postgres.helpers/partition-by

I'm not sure if this is an issue.

ukriish commented 6 years ago

This is usually fine when you've name spaced the lib.

Not sure if I should rename these. Would have to be a breaking change.

lensgolda commented 6 years ago

you can add (:refer-clojure :exclude [find update partition-by]) after (:require ...) section inside (ns ...)

ukriish commented 6 years ago

closing this issue.

You can either choose to exclude as @lensgolda mentioned or namespace the helpers as sqlh/update