search

nilenso / honeysql-postgres

PostgreSQL extension for honeysql
http://nilenso.com
Eclipse Public License 1.0
193 stars 28 forks source link

Configure CI #46

Closed scimetfoo closed 3 years ago

scimetfoo commented 3 years ago

Addresses #38

kitallis commented 3 years ago

@scimetfoo Could we add a build badge to the README?

p-himik commented 3 years ago

Just noticed something - this PR removes deps.edn and IIRC it will make it impossible to use Git coordinates of the library in projects that require it.

scimetfoo commented 3 years ago

@p-himik that’s a good point. Thanks for bringing it to notice. To use deps and lein together, we had to use a dependency resolution plugin (lein-tools-deps), which happens to rely on Clojure CLI tools. Because of Github Actions’ lack of support for Clojure CLI tools, I chose to get rid of this plugin and deps in the favour of using lein alone. Since we aren’t very heavily reliant on lein, and git coordinates seems to have a more compelling need for this project, I think we’ll get rid of lein in the favour of deps instead.

kitallis commented 3 years ago

@scimetfoo I believe this is ready to be merged, wdyt?

kitallis commented 3 years ago

@scimetfoo I'm making changes for this to run CI via deps now, since lein doesn't exist.

kitallis commented 3 years ago

@scimetfoo I think this works now and the build is green, feel to approve, squash and merge.