nileshsimaria / jtimon

Junos Telemetry Interface client
MIT License
81 stars 29 forks source link

Dialout Changes Broke Dockerfile #122

Open dannyvernals opened 2 years ago

dannyvernals commented 2 years ago

Not really an important issue but I thought I'd just let you know:

The changes to add in Dialout termination support (and subsequent clean up) have broken the Dockerfile

COPY failed: file not found in build context or excluded by .dockerignore: stat certs/self_signed/: file does not exist
make: *** [Makefile:33: docker] Error 1

As far as I understand it, the certs are only needed when acting as a dialout terminator (and when not skipping verification)? So maybe a quick fix would be just to have (pseudo)empty certs/self_signed directory in the repo? Maybe also with some extra documentation in the readme for when dialout is enabled that these certs need to be present.