search

nilisha-jais / Musicophilia

A platform for music lovers
https://musicophilia.netlify.app/
MIT License
42 stars 121 forks source link

spacing corrected #515

Closed nisha331 closed 3 years ago

nisha331 commented 3 years ago

Description

Narrowed height ofnavbar Corrected spacing between the section end and topic .

Checklist

Related Issues or Pull Requests

issue #514

netlify[bot] commented 3 years ago

:heavy_check_mark: Deploy Preview for musicophilia ready!

:hammer: Explore the source changes: 0dc8651df7fe880bb72112c9291d014ea831cc08

:mag: Inspect the deploy log: https://app.netlify.com/sites/musicophilia/deploys/60ef289248a1e2000766515a

:sunglasses: Browse the preview: https://deploy-preview-515--musicophilia.netlify.app/

nilisha-jais commented 3 years ago

Not looking fine in mobile view. There's too much top margin! Screenshot (48)

nisha331 commented 3 years ago

ok @nilisha-jais will fix that

niloysikdar commented 3 years ago

Any update on this @nisha331 ? Now you have to face a large number of merge conflicts. I will suggest to close this pr. Delete this branch, pull the changes to the main branch, and then checkout to a new branch and make changes.

nisha331 commented 3 years ago

yes @niloysikdar Update - was just trying to figure out the code for mobile view which i m not getting . Ok will delete the branch and work on a new one.

saloni-15 commented 3 years ago

Actually, I was working on Navbar to change it's color and navlink hover styling, so I have made it responsive also, and that PR has been merged. Navbar is fine now. You can check here #520

niloysikdar commented 3 years ago

Closing this pr for now. Please open a new one if needed @nisha331