search

nilium / go9p

Automatically exported from code.google.com/p/go9p [note: not the maintainer, just cloned for posterity]
Other
0 stars 0 forks source link

Return value of FOpenOp.Open is ignored #25

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Implement FOpenOp.Open for a file, always return an error
2. Add said file to a server
3. Read said file with "9p read <path-to-file>"

Attaching an example file server (fstest.go)

What is the expected output? What do you see instead?

I expect the read to fail, instead it succeeds.

Please provide any additional information below.

Adding a return instruction in p/srv/file.go:373 after the RespondError call 
fixes the problem.

Original issue reported on code.google.com by alessand...@gmail.com on 23 Aug 2013 at 8:12

Attachments:

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision fbcdb68b9c01.

Original comment by lion...@gmail.com on 23 Aug 2013 at 12:38

GoogleCodeExporter commented 9 years ago 
There was a missing return in Fsrv.Open. Fixed.

Original comment by lion...@gmail.com on 23 Aug 2013 at 12:39