search

nilmtk / nilm_metadata

A schema for modelling meters, measurements, appliances, buildings etc
http://nilm-metadata.readthedocs.org
Apache License 2.0
49 stars 47 forks source link

Make _load_file() public in convert_yaml_to_hdf5 #13

Closed oliparson closed 9 years ago

oliparson commented 9 years ago

The private function _load_file() which loads a yaml file into a dict would be quite useful in the CSVDataStore. Would it make sense to make it public, and maybe call it yaml_file_to_dict() or similar?

JackKelly commented 9 years ago

go for it.

Alternatively, you can import 'private' functions. e.g. from blah import _private

oliparson commented 9 years ago

Good point. I'll import the private function for now, and we can refactor later if necessary.