search

nilmtk / nilm_metadata

A schema for modelling meters, measurements, appliances, buildings etc
http://nilm-metadata.readthedocs.org
Apache License 2.0
49 stars 47 forks source link

Schema item ApplianceModel could be confusing #18

Closed gjwo closed 9 years ago

gjwo commented 9 years ago

Given that Appliances have models, and ApplianceModel refers to the disaggregation model or method being use it might be better named DisaggregationModel or DisaggregationMethod to improve the clarity of the schema.

JackKelly commented 9 years ago

Excellent point. I agree. If you submit a pull request then I'll merge it. This would be a great opportunity for you to try out the process of submitting a pull request (after first forking and making modifications). Github have some great guides on this (search for "github forking repository" or similar). On 23 May 2015 13:14, "Graham Wood" notifications@github.com wrote:

Given that Appliances have models, and ApplianceModel refers to the disaggregation model or method being use it might be better named DisaggregationModel or DisaggregationMethod to improve the clarity of the schema.

— Reply to this email directly or view it on GitHub https://github.com/nilmtk/nilm_metadata/issues/18.

gjwo commented 9 years ago

I am in the middle of generating my household metadata, and I have found some more additions, so I will have a go when I have finished

JackKelly commented 9 years ago

Great stuff. Thank you. No rush. On 23 May 2015 14:44, "Graham Wood" notifications@github.com wrote:

I am in the middle of generating my household metadata, and I have found some more additions, so I will have a go when I have finished

— Reply to this email directly or view it on GitHub https://github.com/nilmtk/nilm_metadata/issues/18#issuecomment-104899931 .

gjwo commented 9 years ago

OK I have done that now

JackKelly commented 9 years ago

Thanks for this. I'll close this issue for now.