search

nilmtk / nilmtk-contrib

Apache License 2.0
114 stars 59 forks source link

Wrong comment in `NILMTK API Tutorial.ipynb` notebook #47

Open Raymundo1 opened 3 years ago

Raymundo1 commented 3 years ago

Hi, I'm trying to correctly understand the implementation of nilmtk-contrib. From NILMTK API Tutorial.ipynb notebook In [3]:, the sample rate in experiment1 is 60. The comment below In [3]: describes that you have set the sample rate at 60Hz. The highest resolution for dataport dataset is 1Hz. I think the comment should be changed to you have set the sample rate at 1/60Hz.

Please correct me if I understand wrong.

Rithwikksvr commented 3 years ago

Yes! You are right @Raymundo1 ! It needs to be changed!