search

nilp0inter / MiSTer_WebMenu

A web interface for MiSTer
Apache License 2.0
60 stars 9 forks source link

Arcade core RBFs listead as well as MRAs #16

Open molnara opened 4 years ago

molnara commented 4 years ago

Describe the bug Arcade core RBFs listed as well as MRAs which is confusing.

Describe your setup

To Reproduce Steps to reproduce the behavior:

  1. Go to 'http://mister'
  2. Click on 'Cores'
  3. Scroll down to 'Arcade'
  4. All the RBFs are being listed alongside the MRAs

Expected behavior Only MRAs should be displayed.

Screenshots

arcade-core-rbfs

Web Browser:

Additional context If I load some of the arcade RBFs, some work, mainly the ones that only support one game, but I don't think arcade RBFs should be displayed. Perfect example is jtcps1, this doesn't do anything if you try to run it, but this core will run any CPS1 MRA.

nilp0inter commented 4 years ago

Yeah, I have to rethink this part.

Do you think hiding the RBF cores if and only if there is an MRA for that core is a good approach?

molnara commented 4 years ago

I would just exclude /_Arcade/cores

I’m pretty sure all arcade cores use mra files now anyways.

nilp0inter commented 4 years ago

I am trying to avoid using the directory structure to infer information about the cores given that a lot of people have different directory layouts.

I will test the idea of hiding RBF which are mentioned in an MRA and publish an RC for you to try.

molnara commented 4 years ago

_Arcade/cores is the standard location which the official update script uses. As I was mentioning before, if we have a settings option, we could just change it if it deviates from the default.

I would probably have the following settings with default settings: Arcade core path /fat/_Arcade/cores Arcade MRA path /fat/_Arcade Console path /fat/_Consoles Computer path /fat/_Computers Games path /fat/games