search

nilp0inter / MiSTer_WebMenu

A web interface for MiSTer
Apache License 2.0
60 stars 9 forks source link

MRA not showing, caused by error in xml #9

Open pividivi opened 4 years ago

pividivi commented 4 years ago

I am giving feedback about: Certain MRA's are not showing up in the webmenu

I believe that because: I found out that those mra files all have an XML error. What I found is that most of them have an & character in them and that generates an error during scanning, causing them not to show up in the WebMenu. When I correct the & character by replacing it with &, then the mra magically appears!

But: This seems an error in the MRA and not the webmenu, but maybe you can be "lenient" in the scanning process, by letting them appear despite the error?

nilp0inter commented 4 years ago

I think those MRA should, at least, be reported through the web interface.

This will help MRA developers to know their MRA files are malformed.

pividivi commented 4 years ago

I think you understand what I was saying, but reading back my posting I saw that maybe I wasn't completely clear in my wording, so for clarification:

By "have an & character in them", I mean that that character is present within the MRA file; not in the title of the MRA file.

For example:

<misterromdescription>
    <name>Flicky (128k Version, not encrypted)</name>
    <mameversion>0217</mameversion>
    <setname>flickys2</setname>
    <mratimestamp>201912300000</mratimestamp>
    <year>1984</year>
    <manufacturer>Sega</manufacturer>
    <category>Maze / Cat & Mouse</category>
    <category>Platform</category>
    <rbf>segasys1</rbf>

As you see, the <category> line says Cat & Mouse. This & character generates the XML error. It should read: Cat &amp; Mouse