search

nilportugues / laravel5-jsonapi-dingo

Laravel5 JSONAPI and Dingo together to build APIs fast
http://nilportugues.com
MIT License
30 stars 3 forks source link

Laravel 5.6 install issue #7

Open scryba opened 6 years ago

scryba commented 6 years ago

The response I get when trying to install on Laravel 5.6;

`composer require nilportugues/laravel5-json-api-dingo Using version ^1.0 for nilportugues/laravel5-json-api-dingo ./composer.json has been updated Loading composer repositories with package information Updating dependencies (including require-dev) Your requirements could not be resolved to an installable set of packages.

Problem 1

Installation failed, reverting ./composer.json to its original content.

`

nilportugues commented 6 years ago

I haven't tried laravel 5.6, but looks like I need to relax the composer.json dependencies in order to make it work with most versions... or create a new release for laravel 5.6.

scryba commented 6 years ago

how can I help I tried to fork this project and do the changes but does not seem to come from this particular package?

gendronb commented 6 years ago

Hi @nilportugues,

Any progress on this?

gendronb commented 6 years ago

Hi again,

For those interested, I managed to quickly solve the installation problem with these steps (with Laravel 5.7):

  1. Forked the nilportugues/laravel5-json-api repo, created a new branch (3.0);
  2. Updated its symfony/psr-http-message-bridge dependency to "^1.0";
  3. Did a quick correction to src/NilPortugues/Laravel5/JsonApi/Laravel5JsonApiServiceProvider.php, in order to return a Laravel52Provider any Laravel versions > 5.2 (replaced line 60-62 with $provider = new Laravel52Provider(); );
  4. FInally, forked the current repo, and updated the nilportugues/laravel5-json-api dependency to use the new branch (3.0)...

Works perfectly afterwards.

However, this doesn't solve https://github.com/nilportugues/laravel5-jsonapi-dingo/issues/5...