search

nilportugues / laravel5-jsonapi

Laravel 5 JSON API Transformer Package
http://nilportugues.com
MIT License
310 stars 70 forks source link

copying controller actions to the LumenJSONAPIController #105

Open mansona opened 8 years ago

mansona commented 8 years ago

Hi Folks,

First of all thanks for the great library 👍 It's always good to see people solving the hard problems so the rest of us don't have to don't have to 😉

I was trying to get this library to work with lumen (instead of Laravel) and it didn't seem to work. I noticed that things seemed to be pulled out of the JsonApiTrait in this commit https://github.com/nilportugues/laravel5-jsonapi/commit/c96e65f9500b72763c540081f672c1a53bbfc0d8 but they weren't added to the LumenJsonApiController at the same time.

The changes in this PR work for me when it comes to simple objects using Eloquent with Lumen but it doesn't seem to work with relationships, I will continue that part of the discussion on the issue here https://github.com/nilportugues/php-api-transformer/issues/10

mansona commented 8 years ago

I don't know why the tests are failing, but from what I can see master is also having issues 🤔