search

nilportugues / php-json-api

JSON API transformer outputting valid (PSR-7) API Responses.
http://nilportugues.com
MIT License
71 stars 35 forks source link

fix ListResource to adhere to fields and include query parameters #51

Closed marcogrueter closed 8 years ago

samgreenwood commented 8 years ago

Any idea when this will get merged?

nilportugues commented 8 years ago

@samgreenwood mind writing a test for it? I was going to do this myself, and I will before or during easter if not... but if you want this merged ASAP, provide a meaningful passing test.

I'm quite happy it didn't break anything, and I'm quite confident it won't break anything, but I still believe a test is required.

marcogrueter commented 8 years ago

Sorry, that should have been my thing. Do you think it's ok if I copy the "testItWillSerializeToJsonApiAnArrayOfObjects" to "testItWillSerializeToJsonApiAnArrayOfObjectsAndFilterIncluded"? I'm not that familiar with this repo.

nilportugues commented 8 years ago

@marcogrueter yes that will do.