search

nilportugues / sql-repository

[PHP 7] SQL Repository implementation
http://nilportugues.com
MIT License
36 stars 3 forks source link

[Insight] Unused method, property, variable or parameter - in src/Infrastructure/…/Sql/SqlRepository.php, line 366 #5

Closed nilportugues closed 8 years ago

nilportugues commented 8 years ago

in src/Infrastructure/Model/Repository/Sql/SqlRepository.php, line 366

This distinctFields local variable is declared but never used. You should remove it.


        if ($pageable) {
            $fields = $this->getColumns($pageable->fields());
            $columns = (!empty($fields)) ? $fields : ['*'];

            if (count($distinctFields = $pageable->distinctFields()->get()) > 0) {
                $columns = $this->getColumns($pageable->distinctFields());
                if (empty($columns)) {
                    $columns = ['*'];
                }

Posted from SensioLabsInsight