search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Update luigi scheduler progressbar for gbasf2 tasks #109

Closed meliache closed 3 years ago

meliache commented 3 years ago

Since we now have luigi 3 as a dependency, we can make use of the progressbar-features for the scheduler. Here a small screenshot. The uppermost worker is a local merger task where I set the progressbar manually in its run method. The other progressbars are of gbasf2 tasks, each of which supervises a gbasf2 grid project consisting of many individual jobs. So for those, the progressbar that I implemented with this PR indicates how many of those jobs in that project are done. grafik

meliache commented 3 years ago

Now also added the gbasf2 job status to the central scheduler view. grafik

codecov-commenter commented 3 years ago

Codecov Report

Merging #109 (d6630f0) into main (573ba5f) will increase coverage by 0.12%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   55.69%   55.81%   +0.12%     
==========================================
  Files          23       23              
  Lines        1449     1453       +4     
==========================================
+ Hits          807      811       +4     
  Misses        642      642
Impacted Files Coverage Δ
b2luigi/batch/processes/gbasf2.py 38.79% <100.00%> (+0.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 573ba5f...d6630f0. Read the comment docs.

nils-braun commented 3 years ago

Thanks @meliache - looks nice. Is there a way to have less digits in the percentage in the progress bar (I did not check the code so far)

meliache commented 3 years ago

The function takes a numerical percentage as an input, I haven't checked if it also takes a format string (writing from mobile now), but I could just round the number to some decimal places.