Closed ArturAkh closed 3 years ago
Merging #113 (c95864a) into main (8606fab) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #113 +/- ##
=======================================
Coverage 55.81% 55.81%
=======================================
Files 23 23
Lines 1453 1453
=======================================
Hits 811 811
Misses 642 642
Impacted Files | Coverage Δ | |
---|---|---|
b2luigi/batch/processes/gbasf2.py | 38.79% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 8606fab...c95864a. Read the comment docs.
Thanks a lot. I like that you didn't remove the old test outputs, so I know that this is still backwards compatible to the old releases. :+1: Not sure if this will work for future releases, maybe we can be a bit smarter than splitting on " to "
, but anyways it's an improvement on the previous version and fixes a bug, so I think I can merge this as is.
Any further actions for this PR required?
Any further actions for this PR required?
Nope, LGTM, for some reason I thought you maybe want to add something or maybe I also just forgot about this PR, thanks for the reminder.
Any further actions for this PR required?
Nope, LGTM, for some reason I thought you maybe want to add something or maybe I also just forgot about this PR, thanks for the reminder.
Ok, thanks for the merging in the PR!
Fixes issue #112