nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Fixing parsing problems for failed downloads due to new syntax #113

Closed ArturAkh closed 3 years ago

ArturAkh commented 3 years ago

Fixes issue #112

codecov-commenter commented 3 years ago

Codecov Report

Merging #113 (c95864a) into main (8606fab) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   55.81%   55.81%           
=======================================
  Files          23       23           
  Lines        1453     1453           
=======================================
  Hits          811      811           
  Misses        642      642           
Impacted Files Coverage Δ
b2luigi/batch/processes/gbasf2.py 38.79% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8606fab...c95864a. Read the comment docs.

meliache commented 3 years ago

Thanks a lot. I like that you didn't remove the old test outputs, so I know that this is still backwards compatible to the old releases. :+1: Not sure if this will work for future releases, maybe we can be a bit smarter than splitting on " to ", but anyways it's an improvement on the previous version and fixes a bug, so I think I can merge this as is.

ArturAkh commented 3 years ago

Any further actions for this PR required?

meliache commented 3 years ago

Any further actions for this PR required?

Nope, LGTM, for some reason I thought you maybe want to add something or maybe I also just forgot about this PR, thanks for the reminder.

ArturAkh commented 3 years ago

Any further actions for this PR required?

Nope, LGTM, for some reason I thought you maybe want to add something or maybe I also just forgot about this PR, thanks for the reminder.

Ok, thanks for the merging in the PR!