search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Workaround for basf2 externals 10 ROOT memory error #115

Closed meliache closed 3 years ago

meliache commented 3 years ago

vm.getAliasNames returns a std::vector<string>, which in the ROOT version from the basf2 externals v10 needs to be explicitly converted to python strings (str), otherwise we get memory errors due to the C++ object lifetime. See 1 and 2.

This solves issue #114 reported by @dferlewicz

codecov-commenter commented 3 years ago

Codecov Report

Merging #115 (d64538c) into main (573ba5f) will increase coverage by 0.12%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
+ Coverage   55.69%   55.81%   +0.12%     
==========================================
  Files          23       23              
  Lines        1449     1453       +4     
==========================================
+ Hits          807      811       +4     
  Misses        642      642
Impacted Files Coverage Δ
b2luigi/batch/processes/gbasf2.py 38.79% <0.00%> (+0.62%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 573ba5f...d64538c. Read the comment docs.