Rename `MasterTask`'s in examples to something less culturally sensitive

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple

GNU General Public License v3.0

17 stars 11 forks source link

Rename `MasterTask`'s in examples to something less culturally sensitive #117

Closed meliache closed 3 years ago

meliache commented 3 years ago

We have already made our main branch main and we could follow through by replacing all examples in the documentation where the implementation of luigi.WrapperTask is named MasterTask by something else. Suggestions:

MainTask
WrapperTask -- In this case the base name would be the same as the class it inherits from, just in a different namespace. Maybe it would be better a meaningful prefix to convey what it does, e.g. ReconstructionWrapperTask or AnalysisWrapperTask

philiptgrace commented 3 years ago

The systematic corrections framework uses AggregatorTask, which I quite like.

nils-braun commented 3 years ago

Both are fine with me - thanks for this reasonable change @meliache