philiptgrace commented 3 years ago

Added two new settings, both used in setup_dirac_proxy.

gbasf2_proxy_lifetime: Defaults to 24. When initializing a proxy, set the lifetime to this number of hours.
gbasf2_min_proxy_lifetime: Defaults to 0. During processing, prompt user to reinitialize proxy if remaining proxy lifetime drops below this number of hours.

Addresses #48

codecov-commenter commented 3 years ago

Codecov Report

Merging #127 (7d30e2f) into main (a952a6c) will decrease coverage by 0.18%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
- Coverage   56.73%   56.54%   -0.19%     
==========================================
  Files          23       23              
  Lines        1500     1505       +5     
==========================================
  Hits          851      851              
- Misses        649      654       +5

Impacted Files	Coverage Δ
b2luigi/batch/processes/gbasf2.py	`38.57% <0.00%> (-0.48%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a952a6c...7d30e2f. Read the comment docs.

meliache commented 3 years ago

Thanks a lot for all the help with the gbasf2 wrapper in b2luigi helping with the issues that I never got to. I really feel know that the gbasf2 part finally has a bus factor > 1. This PR looks good to me, I have a minor suggestion (see comment above), you can take a look and make a comment if you think it's a good idea or not (I'm not sure). Then, I will be happy to merge this :)

nils-braun / b2luigi

Improve dirac proxy validity time handling #127

Codecov Report