nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Fix wrong exception arg and fix some types #149

Closed meliache closed 2 years ago

meliache commented 2 years ago

I changed my linter to one that also checks types (i.e. the pyright) language server and found some issues in the gbasf2 batch code, which are fixed with this.

codecov-commenter commented 2 years ago

Codecov Report

Merging #149 (0ad0c1c) into main (a81a814) will decrease coverage by 0.26%. The diff coverage is 16.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   57.38%   57.12%   -0.27%     
==========================================
  Files          23       23              
  Lines        1516     1523       +7     
==========================================
  Hits          870      870              
- Misses        646      653       +7     
Impacted Files Coverage Δ
b2luigi/batch/processes/gbasf2.py 41.17% <16.66%> (-0.69%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a81a814...0ad0c1c. Read the comment docs.