search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

gbasf2 fix: Ensure proxy is initialized before getting user #156

Closed meliache closed 3 years ago

meliache commented 3 years ago

A minor enhancement is that I added caching to the function because I saw it takes some seconds on the command line, which we could save.

codecov-commenter commented 3 years ago

Codecov Report

Merging #156 (3e79bdc) into main (26e2094) will increase coverage by 0.15%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #156      +/-   ##
==========================================
+ Coverage   58.26%   58.42%   +0.15%     
==========================================
  Files          23       23              
  Lines        1531     1532       +1     
==========================================
+ Hits          892      895       +3     
+ Misses        639      637       -2
Impacted Files Coverage Δ
b2luigi/cli/arguments.py 85.71% <ø> (ø)
b2luigi/batch/processes/gbasf2.py 46.08% <100.00%> (+0.58%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ce32eff...3e79bdc. Read the comment docs.