search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Bug with htcondor job status property #164

Closed eckerpatrick closed 2 years ago

eckerpatrick commented 2 years ago

In #158 the get_job_status() function in the subclass HTCondorProcess was changed to a property and is therefore no longer callable. Nevertheless it gets called in https://github.com/nils-braun/b2luigi/blob/main/b2luigi/batch/processes/__init__.py line 135. I think this is a bug.

mschnepf commented 2 years ago

It should be still a function. However, I declared it accidentally as a property in my last commit

meliache commented 2 years ago

Thanks to both of for finding the source of the error and for fixing it so fast :+1: