search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Set get_job_status as function #165

Closed mschnepf closed 2 years ago

mschnepf commented 2 years ago

Fix issue https://github.com/nils-braun/b2luigi/issues/164

codecov-commenter commented 2 years ago

Codecov Report

Merging #165 (f472c9b) into main (4362642) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #165   +/-   ##
=======================================
  Coverage   59.73%   59.73%           
=======================================
  Files          23       23           
  Lines        1530     1530           
=======================================
  Hits          914      914           
  Misses        616      616
Impacted Files Coverage Δ
b2luigi/batch/processes/htcondor.py 62.18% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4362642...f472c9b. Read the comment docs.

meliache commented 2 years ago

LGTM, thanks. Sorry for missing this in the original PR in review. Maybe we could add a unit test that all BatchProcesses implement the interface correctly, but that might be a separate PR.

Also tipp for the future: We now have a CHANGELOG.md in the repository. You can add changes and bugfixes into the ## [Unreleased] section of that file which I will then put under a release section and into the github releases notes when I create a new release. Though if you don't do it, I can also do it myself when I create a new release. Which I will do now, since on Friday I just create a new patch release which now contains this bug.