nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Parametrize DIRAC group #175

Closed Bilokin closed 1 year ago

Bilokin commented 1 year ago

Hi @meliache,

recently, the group policy in gbasf2 was diversified, so the users can now submit the jobs from different DIRAC groups, which have different queue priorities. And since there was created a group belle_systematics we would like to add the corresponding functionality to the b2luigi, which is extremely useful for the systematics framework. To submit a project from a group other than belle, one has to do the following:

In this PR I added two optional b2luigi parameters, gbasf2_proxy_group and gbasf2_project_lpn_path. The latter one is required if the first one is supplied.

meliache commented 1 year ago

Cool, thanks 🙏. Just looking from my phone this looks good to me. I suggest also documenting this in the class comment for the Gbasf2Process at the top of the file, somewhere there is a listing of the important settings for gbasf2 and this will appear on the online sphinx docs. And also add this to the changelog.md under the |Unpublished (meaning not to yet in a release) section. The latter I can also do as a maintainer.

Bilokin commented 1 year ago

Thanks, I wrote the docs and the entry in the changelog, I hope it is correct. There is an issue with the workflow though and I have no clues about it. Can you take a look?

Bilokin commented 1 year ago

Hi @meliache, can you take a look at the github workflow issue and the PR in general?

meliache commented 1 year ago

Sorry @Bilokin, last week I just had no time to look at this because we were aiming for unblinding of our analysis for PRL, so I didn't look at this properly yet.

There is an issue with the workflow though and I have no clues about it. Can you take a look?

Yep, can take a look. Our github action runs the syntax- and style-checker flake8 as a precommit-hook and somehow that fails, but not due to your code but something with that hook. I hadn't seen that before, possibly it's not a mistake on your side, I will check.

meliache commented 1 year ago

The flake8 pre-commit hook seems to fail due to an incompatibility between flake8 v3.9, which was set in the pre-commit config, and importlib_metadata version 5. I found this by googling as https://github.com/python/importlib_metadata/issues/406. I created a PR which upgrades the pre-commit flake8 version to the latest version in #176. This will hopefully fix this issue. If not, I might need to further set importlib_metadata < 5.0.0 in the github action configuration