search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Fix the wrong tmp path for custom group #178

Closed Bilokin closed 1 year ago

Bilokin commented 1 year ago

Hi @meliache,

unfortunately, during my last tests of the custom gbasf2 group functionality I missed the fact that the b2luigi produced empty files as output. This was because the temporary project name was wrong and, apparently, I tested the functionality on my own workflow, which uses hadd and it just creates an empty file when there is no input files. This PR should fix the bug for the custom gbasf2 group.

Bilokin commented 1 year ago

This is related to a weird behaviour in hadd, where the line

hadd -f test.root

doesn't cause any errors, despite that the second argument is missing.

meliache commented 1 year ago

Thanks for the fix and sorry for the delay in reviewing, was quite busy last week and recovered on the weekend by taking time away from my notebook. I removed the "needs a changelog" label because this doesn't change any functionality between releases, just fixes a functionality already described in the changelog for the next releases.

Speaking of that, I bump b2luigi to the next release, which I had been procrastinating for a while. This will make this feature installable via pip3 install b2luigi and also make your documentation visible more visible online on readthedocs.

meliache commented 1 year ago

This is now released in v0.8.1 on github and PyPi.