search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Fix circular import #191

Closed meliache closed 1 year ago

meliache commented 1 year ago

This reverts parts of commit

In commit b80fbedb8a78633524f1eb326ca56f314599cb5d, in addition to bumping the version of b2luigi, I accidentally committed the import sorting done by isort in my editor. That resulted in a circular import. As I thought of this as just a version bump, I didn't look at the test results.

As a fix, I reverted the changes from that commit to the __init__.py, except the version bump.

Thanks @MarcelHoh for reporting.

Resolves #188.

meliache commented 1 year ago

@MarcelHoh do you care to take a look whether this works?

Also it seems our unittests are not running for every PR. Usually, I would expect that github inserts the results of the test in a PR. Maybe it's due to the tests being hung up by the circular import or there is something more fundamentally wrong with our tests or with the CI :shrug: I had ignored that earlier because I don't have much time with my thesis and just wanted to get hotfixes into b2luigi quickly, but you reap what I sow :sweat_smile:

MarcelHoh commented 1 year ago

My little test runs fine. Thanks for the quick fix!

meliache commented 1 year ago

No problem. I just hope that eventually I'll stop adding new errors to releases :sweat_smile: . Maybe I should even consider creating pre-releases / release-candidates. But anyway this is fast-moving project used by few people and I don't give much meaning to release numbers, though for documentation purposes it's nice to have some version numbers with a change log attached.

But I have yet to figure out what's up with the tests. They can be run locally with python3 -m unittest or pytest -v tests but somehow it seems to hang...

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 51.93% and project coverage change: +1.21 :tada:

Comparison is base (1ff3782) 59.20% compared to head (0c0ec91) 60.41%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #191 +/- ## ========================================== + Coverage 59.20% 60.41% +1.21% ========================================== Files 23 23 Lines 1554 1584 +30 ========================================== + Hits 920 957 +37 + Misses 634 627 -7 ``` | [Impacted Files](https://codecov.io/gh/nils-braun/b2luigi/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun) | Coverage Δ | | |---|---|---| | [b2luigi/batch/processes/gbasf2.py](https://codecov.io/gh/nils-braun/b2luigi/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#diff-YjJsdWlnaS9iYXRjaC9wcm9jZXNzZXMvZ2Jhc2YyLnB5) | `49.78% <44.54%> (+3.54%)` | :arrow_up: | | [b2luigi/core/utils.py](https://codecov.io/gh/nils-braun/b2luigi/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#diff-YjJsdWlnaS9jb3JlL3V0aWxzLnB5) | `73.60% <88.88%> (+0.44%)` | :arrow_up: | | [b2luigi/\_\_init\_\_.py](https://codecov.io/gh/nils-braun/b2luigi/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#diff-YjJsdWlnaS9fX2luaXRfXy5weQ==) | `88.46% <100.00%> (ø)` | | | [b2luigi/core/parameter.py](https://codecov.io/gh/nils-braun/b2luigi/pull/191?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#diff-YjJsdWlnaS9jb3JlL3BhcmFtZXRlci5weQ==) | `92.00% <100.00%> (+3.11%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.