codecov-commenter
commented
11 months ago Codecov Report
Attention: 5 lines in your changes are missing coverage. Please review.
Comparison is base (
5815d46) 60.51% compared to head (b8c890a) 60.87%. Report is 9 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #207 +/- ## ========================================== + Coverage 60.51% 60.87% +0.36% ========================================== Files 23 23 Lines 1593 1595 +2 ========================================== + Hits 964 971 +7 + Misses 629 624 -5 ``` | [Flag](https://app.codecov.io/gh/nils-braun/b2luigi/pull/207/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nils-braun/b2luigi/pull/207/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun) | `60.87% <54.54%> (+0.36%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/nils-braun/b2luigi/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun) | Coverage Δ | | |---|---|---| | [b2luigi/\_\_init\_\_.py](https://app.codecov.io/gh/nils-braun/b2luigi/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#diff-YjJsdWlnaS9fX2luaXRfXy5weQ==) | `88.46% <100.00%> (ø)` | | | [b2luigi/batch/processes/gbasf2.py](https://app.codecov.io/gh/nils-braun/b2luigi/pull/207?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#diff-YjJsdWlnaS9iYXRjaC9wcm9jZXNzZXMvZ2Jhc2YyLnB5) | `49.78% <50.00%> (+0.52%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/nils-braun/b2luigi/pull/207/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Changed the default value of the
gbasf2_install_directorysetting and functions which take this as a parameter to the new CVMFS setup script path in gbasf2 v5.8.2. Also fixed the documentation for the setting.The old setting
gbasf2_install_directoryhas been fully deprecated now. Before I tried to use the old setting as a fallback ifgbasf2_setup_pathwas not customized butgbasf2_setup_pathwas. But that resulted in some complicated error-prone logic which is annoying to update when gbasf2 changes their setup path. However I still don't raise an exception when the old setting is used and just raise a warning and fall back to the value ofgbas2_install_directory. Most users just used the default anyway.The changes are also documented in the updated changelog.
This solves #206 reported by @miverone and @0ctagon. Please test if this solves the
FileNotFoundErrorat least.The issue comments contain potential other bugs with the new gbasf2 release, but they seem like they should be a separate more complex issue and I'd like to merge this simple path fix first.
Resolves #206