search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

fix the ds list script so it works with the new gbasf2 version #210

Closed 0ctagon closed 1 year ago

0ctagon commented 1 year ago

With the new gbasf2 version, userCreds changed path and initializeCS() is not automatic anymore. This PR fix the crash happening when b2luigi tries to download the jobs output. Same solution as in #209 .

meliache commented 1 year ago

LGTM :thumbsup:. Just changelog missing, that could be combined with the changelog entry for #209 into a single bulletpoint

codecov-commenter commented 1 year ago

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5815d46) 60.51% compared to head (e1a1cba) 60.80%. Report is 18 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #210 +/- ## ========================================== + Coverage 60.51% 60.80% +0.28% ========================================== Files 23 23 Lines 1593 1597 +4 ========================================== + Hits 964 971 +7 + Misses 629 626 -3 ``` | [Flag](https://app.codecov.io/gh/nils-braun/b2luigi/pull/210/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/nils-braun/b2luigi/pull/210/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun) | `60.80% <46.15%> (+0.28%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files](https://app.codecov.io/gh/nils-braun/b2luigi/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun) | Coverage Δ | | |---|---|---| | [b2luigi/\_\_init\_\_.py](https://app.codecov.io/gh/nils-braun/b2luigi/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#diff-YjJsdWlnaS9fX2luaXRfXy5weQ==) | `88.46% <100.00%> (ø)` | | | [b2luigi/batch/processes/gbasf2.py](https://app.codecov.io/gh/nils-braun/b2luigi/pull/210?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun#diff-YjJsdWlnaS9iYXRjaC9wcm9jZXNzZXMvZ2Jhc2YyLnB5) | `49.57% <41.66%> (+0.31%)` | :arrow_up: | ... and [6 files with indirect coverage changes](https://app.codecov.io/gh/nils-braun/b2luigi/pull/210/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Nils+Braun)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.