search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Added github workflows and removed travis #78

Closed nils-braun closed 3 years ago

nils-braun commented 3 years ago

Solves #74 (except the bumpversion, which can not be solved as we are not using git flow).

So far, whenever there is a new tag, there is in principle also a pipy publish via Travis. However, Travis is a bit flaky sometimes and GitHub actions offer more possibilities anyhow, so let's move to GitHub actions :-)

This PR removes the Travis integration and adds two GitHub actions: one for publishing (whenever a new GitHub release is created, which typically should be done on git tags) and one for the usual tests of PRs. I also moved to codecov in this PR (just because it is nicer).

This can be expanded to also include things like stylechecks (pycodestyle, autopep8, black), isort, flake8 etc - but so far letÄs start with the basics.

codecov-io commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (main@05a1652). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage        ?   49.71%           
=======================================
  Files           ?       23           
  Lines           ?     1392           
  Branches        ?        0           
=======================================
  Hits            ?      692           
  Misses          ?      700           
  Partials        ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 05a1652...7ba2ec7. Read the comment docs.

nils-braun commented 3 years ago

@meliache Feel free to either merge it if you like to comment on it. That is of course only my own proposal

meliache commented 3 years ago

Thanks, looks good to me :slightly_smiling_face:. And if you agree with my one comment above that testing with 3.7 is probably no problem, then I'll happily merge.