search

nils-braun / b2luigi

Task scheduling and batch running for basf2 jobs made simple
GNU General Public License v3.0
17 stars 11 forks source link

Fix b2luigi __version__ being shadowed by luigi #95

Closed meliache closed 3 years ago

meliache commented 3 years ago

The import statement

from luigi import *

also imports the __version__ from luigi and this seems to shadow the b2luigi version defined at the top of the file.

The quick fix was to move the __version__ definition down, but the best would be to no import the luigi version to begin with.

I found this when I checked b2luigi.__version__ on a remote host to check the installed version and saw 3.0.2 as a result, which is the luigi version. I wonder why I didn't see this earlier...

meliache commented 3 years ago

Upps thanks for checking the comment, I think it shows I was tired and in a hurry when writing this :sweat_smile: