search

nilsbore / auvlib

Modern C++ and python library for reading and processing sonar data
https://nilsbore.github.io/auvlib-docs
Other
83 stars 30 forks source link

Only jsf parts of #60 #62

Open nilsbore opened 4 years ago

nilsbore commented 4 years ago

Cherry-picking the parts out of https://github.com/nilsbore/auvlib/pull/60 that are relevant for parsing jsf. The xtf parts that John have done will need a separate PR to figure out what is causing the windows build failure.

nilsbore commented 4 years ago

@xyp8023 So these are only the jsf parts but it's still failing on windows for some reason. I've rebuilt the current master on CI and it's still building so it's not a problem with CI having been updated.

nilsbore commented 4 years ago

Suspicion confirmed: https://github.com/nilsbore/auvlib/pull/63 builds.

xyp8023 commented 4 years ago

Maybe we can do something like this?:

if (MSVC AND ${MSVC_VERSION} GREATER_EQUAL 1915) target_compile_definitions( ${target_name} PRIVATE _ENABLE_EXTENDED_ALIGNED_STORAGE ) endif()

nilsbore commented 4 years ago

If that fixes the problem, that would be a good way to do it. Please open another PR with that change to see if it builds. Make sure to base it on the only_jsf branch.