search

nilsbraden / ttrss-reader-fork

An Android-Client for the self-hosted Tiny Tiny RSS feedreader
https://www.nilsbraden.de/TTRSS-Reader/
151 stars 40 forks source link

Download feed icons and display them in feed list. Fixes #241 #368

Closed MoriTanosuke closed 6 years ago

MoriTanosuke commented 6 years ago

Feed icons are downloaded from ttrss and displayed in the feed item list now. The URL path to feed icons can be set via Preferences, getting it from the server config is not implemented. This can be improved, but I was not clear about when to update the value and I didn't want to fetch it for every request to the server or something similar naive.

The feed icon is displayed in the 2nd line of the feed item list, on the right of the item date. The layout is not nice and centered, but I had to give up on the Android layout... 😞 If there are any improvements I could do, please let me know and I'll update the PR.

I noticed some of the imports were changed too, and I tried to figure out what the usual ordering is, but I am not sure if I did this right. I ordered android.* at the top, which seems the case for many of the files. Please let me know if I should re-order them.

MoriTanosuke commented 6 years ago

I noticed that I messed up while rebasing on master, should be ok now.