search

nilsbraden / ttrss-reader-fork

An Android-Client for the self-hosted Tiny Tiny RSS feedreader
https://www.nilsbraden.de/TTRSS-Reader/
149 stars 40 forks source link

Swiping left to right on an article toggles its read state #430

Open lostmsu opened 3 years ago

lostmsu commented 3 years ago

This implements #275

Refactored custom gesture listeners a bit. When a left-to-right swipe is performed on an article headline in a list, toggles article read state.

Currently this precludes any other behavior, that existed before this change.

I did not test the new swipe handler on anything but articles. Can happily do that if somebody can point me to test steps for feed navigation.

nilsbraden commented 3 years ago

I'm not sure I understood this correctly. Does this affect only the behaviour in FeedHeadlineView? And there it only changes what happens when you swipe left-to-right over one article (so not going diagonally but only straight), then the article is marked read, otherwise the normal fling behaviour is processed?

Not sure if this is practical actually. Maybe we should try to add some kind of visual feedback on this, it might lead to confusion otherwise.

lostmsu commented 3 years ago

The visual feedback currently: the article changes read/unread mark after gesture is done.

I know feature is useful: I used it extensively before switching to TTRSS-Reader from Feedly.

Visual feedback would be nice, but frankly I am too lazy to program it )

lostmsu commented 3 years ago

only changes what happens when you swipe left-to-right over one article (so not going diagonally but only straight), then the article is marked read, otherwise the normal fling behaviour is processed?

That sounds right. Though I do not know what the normal fling behavior is, so I never tested it.

lostmsu commented 2 weeks ago

Any plans to merge these? I can fix the merge conflicts. Had to use my own fork for 3 years now for these two features.